Skip to content

test: fix HEIC tests#61858

Merged
provokateurin merged 1 commit into
masterfrom
test/heic
Jul 7, 2026
Merged

test: fix HEIC tests#61858
provokateurin merged 1 commit into
masterfrom
test/heic

Conversation

@susnux

@susnux susnux commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux added this to the Nextcloud 35 milestone Jul 6, 2026
@susnux susnux added 3. to review Waiting for reviews tests Related to tests labels Jul 6, 2026
solracsf
solracsf reviewed Jul 6, 2026
View reviewed changes
Comment thread .github/workflows/phpunit-sqlite.yml Outdated
@solracsf solracsf mentioned this pull request Jul 6, 2026
Open
7 tasks
come-nc
come-nc reviewed Jul 7, 2026
View reviewed changes
Comment thread tests/lib/Preview/HEICTest.php
@come-nc

come-nc commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@susnux Tests passed so it would be good to finish and merge this, the tests are failing on all other PRs.

@susnux
test: fix HEIC tests
1479eba 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux marked this pull request as ready for review July 7, 2026 11:31
@susnux susnux requested a review from a team as a code owner July 7, 2026 11:31
@susnux susnux requested review from ArtificialOwl, come-nc, icewind1991, provokateurin, salmart-dev and solracsf and removed request for a team July 7, 2026 11:31
@provokateurin provokateurin enabled auto-merge July 7, 2026 11:50
@susnux

susnux commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@provokateurin provokateurin merged commit bc162c7 into master Jul 7, 2026
235 of 248 checks passed
@provokateurin provokateurin deleted the test/heic branch July 7, 2026 13:10
@backportbot backportbot Bot mentioned this pull request Jul 7, 2026
Merged
@DerDreschner

This comment was marked as outdated.

Sign in to view
@backportbot backportbot Bot mentioned this pull request Jul 7, 2026
Merged
@DerDreschner

DerDreschner commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

33 is affected as well: https://github.com/nextcloud/server/actions/runs/28898692026/job/85729925857?pr=61891#step:7:129 (PostgreSQL?!) and https://github.com/nextcloud/server/actions/runs/28898692027/job/85730826875?pr=61891#step:8:127

Edit: No, it's not. The tests around HEIC are just a bit flaky at the moment... So, I closed the backport PR for stable33.

@come-nc

come-nc commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@DerDreschner Are you sure? The same tests are failing on stable33 backports

@come-nc

come-nc commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/backport to stable32

@come-nc

come-nc commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

(had the same issue in stable32)

@backportbot backportbot Bot mentioned this pull request Jul 9, 2026
Merged
@DerDreschner

DerDreschner commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@DerDreschner Are you sure? The same tests are failing on stable33 backports

I'm not sure. As this PR only makes changes to the phpunit-sqlite workflow, I suspected only fails in that test to be associated with this fix. But I had the same issues on PGSQL and MariaDB as well - but only sometimes... That's where my confusion comes from. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsf solracsf solracsf approved these changes
@provokateurin provokateurin provokateurin approved these changes
@come-nc come-nc come-nc approved these changes
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews tests Related to tests

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux @come-nc @DerDreschner @solracsf @provokateurin